RE: [PATCH v17] pwm: Add Renesas RZ/G2L MTU3a PWM driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

Thanks for the feedback.

> Subject: Re: [PATCH v17] pwm: Add Renesas RZ/G2L MTU3a PWM driver
> 
> Hello,
> 
> On Mon, May 22, 2023 at 06:14:49PM +0100, Biju Das wrote:
> > base-commit: 9f258af06b6268be8e960f63c3f66e88bdbbbdb0
> > prerequisite-patch-id: 7d5c55db908971d16a58eb46b25d42dfb0f680ec
> > prerequisite-patch-id: 6c15d33bb612750523d14af87a5cf9e6ff142540
> > prerequisite-patch-id: e5e4d86a0a012a59f585b84ce7ae0d3f047787dc
> > prerequisite-patch-id: d62b4e1326f1518fd30eb98a37bfb4998573979a
> > prerequisite-patch-id: 15bf63b610cab275387a2bbee7ab2a0a48414f75
> 
> My working copy doesn't contain
> 9f258af06b6268be8e960f63c3f66e88bdbbbdb0, so I wonder what is the base
> you used here. Also the other prerequisite patches are unclear to me and
> I didn't find them[1]. I assume it's stuff around
> 
> 	654c293e1687 mfd: Add Renesas RZ/G2L MTU3a core driver

Yes,

base-commit: 9f258af06b62 is based on Linux-next as PWM git [2], does not have the commit 
654c293e1687 'mfd: Add Renesas RZ/G2L MTU3a core driver'

Other patches are not in mainline( config, device tree and CI related).

0001-CI-Add-CI-build.patch
0002-renesas-defconfig.patch
0003-Enable-MTU3.patch
0004-defconfig-Enable-MTU3.patch
0005-renesas_defconfig-Enable-MTU3.patch

[2]
https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git/log/?qt=grep&q=biju.das&h=for-next

> 
> (which is in v6.4-rc1)? I recommend duplicating this information in
> human readable form in the cover letter (or below the --- if it's only a
> single patch).
> 
> So this patch was probably not tested by the build bots.

OK, Will resend with base-commit for mainline 6.4-rc1.

Will drop other prerequisite patches.

Cheers,
Biju

> Otherwise I think this is good enough to go in now, so:
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> Thanks
> Uwe
> 




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux