Hi Sakari,
On Wed, May 24, 2023 at 11:53 AM Sakari Ailus
<sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> On Tue, May 23, 2023 at 05:42:21PM +0200, Geert Uytterhoeven wrote:
> > On R-Car M2-W:
> >
> > rcar_fdp1 fe940000.fdp1: FDP1 Unidentifiable (0x02010101)
> > rcar_fdp1 fe944000.fdp1: FDP1 Unidentifiable (0x02010101)
> >
> > Although the IP Internal Data Register on R-Car Gen2 is documented to
> > contain all zeros, the actual register contents seem to match the FDP1
> > version ID of R-Car H3 ES1.*, which has just been removed.
> > Fortunately this version is not used for any other purposes yet.
> >
> > Fix this by re-adding the ID, now using an R-Car Gen2-specific name.
> >
> > Fixes: af4273b43f2bd9ee ("media: renesas: fdp1: remove R-Car H3 ES1.* handling")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> > ---
> > Version register contents verified on R-Car H2 ES1.0, R-Car M2-W ES1.0 &
> > ES3.0, and R-Car E2 ES1.0. I couldn't get hold of an R-Car M2-N.
> >
> > v3:
> > - Add Reviewed-by,
>
> V2 is already in my PR to Mauro. I hope that's fine!
Np, I wasn't aware of that. Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
