Hi Conor, Thanks for the feedback. > Subject: Re: [PATCH v4 09/11] regulator: dt-bindings: Add Renesas > RAA215300 PMIC bindings > > On Thu, May 18, 2023 at 12:36:41PM +0100, Biju Das wrote: > > Document Renesas RAA215300 PMIC bindings. > > > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > > Memory, with Built-In Charger and RTC. > > > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > > The internally compensated regulators, built-in Real-Time Clock (RTC), > > 32kHz crystal oscillator, and coin cell battery charger provide a > > highly integrated, small footprint power solution ideal for > > System-On-Module (SOM) applications. A spread spectrum feature > > provides an ease-of-use solution for noise-sensitive audio or RF > > applications. > > + reg: > > + maxItems: 2 > > + > > + reg-names: > > + items: > > + - const: main > > + - const: rtc > > > +required: > > + - compatible > > + - reg > > + - reg-names > > Out of curiosity as much as anything else, why do you need reg-names if > the two registers are always required? The device has always 2 address spaces and "reg-names" provides a means of clear differentiation compared to indices. By enforcing "reg-names" as required property, dt can do some schema-validation forcing users to specify "reg-names" in device tree. Implementation wise, we use "rtc" for getting resource details while creating the second i2c device which overrides the default address. Strictly speaking reg-names is not required, but from a validation perspective and since driver is using the same "resource-name" it is better to have it?? Please share your thoughts. Cheers, Biju
