Hi Biju, On Sat, May 13, 2023 at 6:53 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > The RAA215300 is a 9-channel PMIC that consists of > * Internally compensated regulators > * built-in Real Time Clock (RTC) > * 32kHz crystal oscillator > * coin cell battery charger > > The RTC on RAA215300 is similar to the IP found in the ISL1208. > The existing driver for the ISL1208 works for this PMIC too, > however the RAA215300 exposes two devices via I2C, one for the RTC > IP, and one for everything else. The RTC IP has to be enabled > by the other I2C device, therefore this driver is necessary to get > the RTC to work. > > The external oscillator bit is inverted on PMIC version 0x11. > > Add PMIC RAA215300 driver for enabling RTC block and instantiating > RTC device based on PMIC version. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > --- > v2->v3: > * Updated commit description > * Added support for handling "renesas,rtc-enabled" property. > * Based on PMIC version, it instantiates rtc device by calling i2c_new_ > ancillary_device(). Thanks for the update! > RFC->V2: > * Dropped MODULE_SOFTDEP from the driver as it is added in RTC platform > driver. > --- > drivers/mfd/Kconfig | 7 +++ > drivers/mfd/Makefile | 2 + > drivers/mfd/raa215300.c | 102 ++++++++++++++++++++++++++++++++++++++++ Note that this driver no longer uses any MFD APIs... Perhaps it should be moved to drivers/regulator/ instead? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds