On Wed, May 10, 2023 at 09:27:46AM +0200, Geert Uytterhoeven wrote:
> On Wed, May 10, 2023 at 8:59 AM Wolfram Sang
> <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> ...
> > static int rcar_pcie_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > struct rcar_pcie_host *host;
> > struct rcar_pcie *pcie;
> > u32 data;
> > - int err;
> > + int i, err;
>
> unsigned int i?
>
> > struct pci_host_bridge *bridge;
>
> The (lack of) reverse-Xmas-tree ordering is hurting my OCD, but that's
> not your fault...
I usually put things in order of use, with initializations from
parameters first. Happily, that is often a pretty good approximation
of reverse-Xmas-tree, as it is here, so I'm all in favor of moving
"struct pci_host_bridge" up there :)
Bjorn
