Re: [PATCH 2/2] clk: vc7: Use device_get_match_data() instead of of_device_get_match_data()

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Marek,

On Sun, May 7, 2023 at 3:42 PM Marek Vasut
<marek.vasut+renesas@xxxxxxxxxxx> wrote:
> Use device_get_match_data() which, unlike of_device_get_match_data(),
> is compatible with other firmware interfaces than just OF.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/clk/clk-versaclock7.c
> +++ b/drivers/clk/clk-versaclock7.c
> @@ -1108,7 +1108,7 @@ static int vc7_probe(struct i2c_client *client)
>
>         i2c_set_clientdata(client, vc7);
>         vc7->client = client;
> -       vc7->chip_info = of_device_get_match_data(&client->dev);
> +       vc7->chip_info = device_get_match_data(&client->dev);
>
>         vc7->pin_xin = devm_clk_get(&client->dev, "xin");
>         if (PTR_ERR(vc7->pin_xin) == -EPROBE_DEFER) {

LGTM, but probably you want to include <linux/property.h> explicitly?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds