Hi Uwe,
Thank you for the patch.
On Sun, May 07, 2023 at 06:26:02PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> index faacfee24763..fa32115320ca 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
> @@ -171,7 +171,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(shmob_drm_pm_ops,
> * Platform driver
> */
>
> -static int shmob_drm_remove(struct platform_device *pdev)
> +static void shmob_drm_remove(struct platform_device *pdev)
> {
> struct shmob_drm_device *sdev = platform_get_drvdata(pdev);
> struct drm_device *ddev = sdev->ddev;
> @@ -180,8 +180,6 @@ static int shmob_drm_remove(struct platform_device *pdev)
> drm_kms_helper_poll_fini(ddev);
> free_irq(sdev->irq, ddev);
> drm_dev_put(ddev);
> -
> - return 0;
> }
>
> static int shmob_drm_probe(struct platform_device *pdev)
> @@ -285,7 +283,7 @@ static int shmob_drm_probe(struct platform_device *pdev)
>
> static struct platform_driver shmob_drm_platform_driver = {
> .probe = shmob_drm_probe,
> - .remove = shmob_drm_remove,
> + .remove_new = shmob_drm_remove,
> .driver = {
> .name = "shmob-drm",
> .pm = pm_sleep_ptr(&shmob_drm_pm_ops),
> --
> 2.39.2
>
--
Regards,
Laurent Pinchart
