Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v8 3/4] arm64: dts: renesas: rzg2l-smarc: Enable DU and
> link with DSI
>
> Hi Biju,
>
> On Mon, Apr 24, 2023 at 6:39 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Enable DU and link with DSI on RZ/{G2L,V2L} SMARC EVK.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > @@ -49,6 +49,7 @@ ports {
> > port@0 {
> > reg = <0>;
> > dsi0_in: endpoint {
> > + remote-endpoint = <&du_out_dsi>;
> > };
> > };
> >
> > @@ -62,6 +63,26 @@ dsi0_out: endpoint {
> > };
> > };
> >
> > +&du {
> > + status = "okay";
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > + du_out_dsi: endpoint {
> > + remote-endpoint = <&dsi0_in>;
> > + };
> > + };
> > +
> > + port@1 {
> > + reg = <1>;
> > + };
>
> Do you need port@1 if it is not connected to anything?
> If yes, don't the port@ subnodes and reg properties belong in the SoC-
> specific .dtsi?
If I remove port@1, I get below warnings
DTC arch/arm64/boot/dts/renesas/r9a07g044l2-smarc.dtb
arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi:69.8-79.4: Warning (graph_child_address): /soc/display@10890000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
DTC arch/arm64/boot/dts/renesas/r9a07g054l2-smarc.dtb
arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi:69.8-79.4: Warning (graph_child_address): /soc/display@10890000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
Rob, Krzysztof Kozlowski,
>From DT perspective, Is this warning expected?
I see lot of similar warnings related to single vs multiple ports issue.
DTC arch/arm64/boot/dts/renesas/r8a779a0-falcon.dtb
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1124.12-1134.7: Warning (graph_child_address): /soc/video@e6ef0000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1152.12-1162.7: Warning (graph_child_address): /soc/video@e6ef1000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1180.12-1190.7: Warning (graph_child_address): /soc/video@e6ef2000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1208.12-1218.7: Warning (graph_child_address): /soc/video@e6ef3000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1236.12-1246.7: Warning (graph_child_address): /soc/video@e6ef4000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1264.12-1274.7: Warning (graph_child_address): /soc/video@e6ef5000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1292.12-1302.7: Warning (graph_child_address): /soc/video@e6ef6000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1320.12-1330.7: Warning (graph_child_address): /soc/video@e6ef7000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2405.12-2415.7: Warning (graph_child_address): /soc/isp@fed00000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2571.12-2581.7: Warning (graph_child_address): /soc/isp@fed30000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
DTC arch/arm64/boot/dts/renesas/r8a779a0-falcon.dtb
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1124.12-1134.7: Warning (graph_child_address): /soc/video@e6ef0000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1152.12-1162.7: Warning (graph_child_address): /soc/video@e6ef1000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1180.12-1190.7: Warning (graph_child_address): /soc/video@e6ef2000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1208.12-1218.7: Warning (graph_child_address): /soc/video@e6ef3000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1236.12-1246.7: Warning (graph_child_address): /soc/video@e6ef4000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1264.12-1274.7: Warning (graph_child_address): /soc/video@e6ef5000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1292.12-1302.7: Warning (graph_child_address): /soc/video@e6ef6000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:1320.12-1330.7: Warning (graph_child_address): /soc/video@e6ef7000/ports/port@2: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2405.12-2415.7: Warning (graph_child_address): /soc/isp@fed00000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/r8a779a0.dtsi:2571.12-2581.7: Warning (graph_child_address): /soc/isp@fed30000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
Cheers,
Biju
>
> > + };
> > +};
> > +
> > &i2c1 {
> > adv7535: hdmi@3d {
> > compatible = "adi,adv7535";
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
