Hi Manivannan,
> From: Manivannan Sadhasivam, Sent: Saturday, April 22, 2023 11:01 PM
>
> On Tue, Apr 18, 2023 at 09:23:56PM +0900, Yoshihiro Shimoda wrote:
> > One of controllers requires vender-specific initialization before
>
> Again, specify the exact controller.
I got it. I'll revise the description.
> > .ep_init(). To use dw->dbi and dw->bum-lanes in the initialization
>
> num-lanes
Oops. I'll fix it.
Best regards,
Yoshihiro Shimoda
> - Mani
>
> > code, introduce .ep_pre_init() into struct dw_pcie_ep_ops.
> > Also introduce .ep_deinit() to disable the controller by using
> > vender-specific de-initialization.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> > drivers/pci/controller/dwc/pcie-designware-ep.c | 6 ++++++
> > drivers/pci/controller/dwc/pcie-designware.h | 2 ++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> > index 2458ca2bc0e4..a011db7e3064 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> > @@ -670,6 +670,9 @@ void dw_pcie_ep_exit(struct dw_pcie_ep *ep)
> > struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
> > struct pci_epc *epc = ep->epc;
> >
> > + if (ep->ops->ep_deinit)
> > + ep->ops->ep_deinit(ep);
> > +
> > dw_pcie_edma_remove(pci);
> >
> > if (ep->intx_mem)
> > @@ -783,6 +786,9 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
> > ep->phys_base = res->start;
> > ep->addr_size = resource_size(res);
> >
> > + if (ep->ops->ep_pre_init)
> > + ep->ops->ep_pre_init(ep);
> > +
> > dw_pcie_version_detect(pci);
> >
> > dw_pcie_iatu_detect(pci);
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> > index c4bdfed7b2e2..ae8ac15e53dc 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.h
> > +++ b/drivers/pci/controller/dwc/pcie-designware.h
> > @@ -336,7 +336,9 @@ struct dw_pcie_rp {
> > };
> >
> > struct dw_pcie_ep_ops {
> > + void (*ep_pre_init)(struct dw_pcie_ep *ep);
> > void (*ep_init)(struct dw_pcie_ep *ep);
> > + void (*ep_deinit)(struct dw_pcie_ep *ep);
> > int (*raise_irq)(struct dw_pcie_ep *ep, u8 func_no,
> > enum pci_epc_irq_type type, u16 interrupt_num);
> > const struct pci_epc_features* (*get_features)(struct dw_pcie_ep *ep);
> > --
> > 2.25.1
> >
>
> --
> மணிவண்ணன் சதாசிவம்
