Re: [PATCH] can: rcar_canfd: Fix plain integer in transceivers[] init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Looks fine to me.

On Wed Mar 29, 2023 at 8:40 AM CEST, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> With C=1:
>
>     drivers/net/can/rcar/rcar_canfd.c:1852:59: warning: Using plain integer as NULL pointer
>
> Fixes: a0340df7eca4f28e ("can: rcar_canfd: Add transceiver support")
> Reported-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20230328145658.7fdbc394@xxxxxxxxxx
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>  drivers/net/can/rcar/rcar_canfd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c
> index ecdb8ffe2f670c9b..11626d2a0afb1a90 100644
> --- a/drivers/net/can/rcar/rcar_canfd.c
> +++ b/drivers/net/can/rcar/rcar_canfd.c
> @@ -1848,7 +1848,7 @@ static void rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch)
>
>  static int rcar_canfd_probe(struct platform_device *pdev)
>  {
> -       struct phy *transceivers[RCANFD_NUM_CHANNELS] = { 0, };
> +       struct phy *transceivers[RCANFD_NUM_CHANNELS] = { NULL, };
>         const struct rcar_canfd_hw_info *info;
>         struct device *dev = &pdev->dev;
>         void __iomem *addr;
> --
> 2.34.1


Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx>

BR
Steen




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux