On Tue, Mar 28, 2023 at 19:40, Ido Schimmel <idosch@xxxxxxxxxx> wrote: > On Sun, Mar 26, 2023 at 05:41:06PM +0200, Hans Schultz wrote: >> On Mon, Mar 20, 2023 at 10:44, Ido Schimmel <idosch@xxxxxxxxxx> wrote: >> >> + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \ >> >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q >> >> + tc_check_packets "dev $swp2 egress" 1 1 >> >> + check_fail $? "Dynamic FDB entry did not age out" >> > >> > Shouldn't this be check_err()? After the FDB entry was aged you want to >> > make sure that packets received via $swp1 with SMAC being $mac are no >> > longer forwarded by the bridge. >> >> I was thinking that check_fail() will pass when tc_check_packets() does >> not see any packets, thus the test passing here when no packets are forwarded? > > What do you mean by "I was *thinking*"? How is it possible that you are > submitting a selftest that you didn't bother running?! > Sorry, but I have sent you several emails telling you about the problems I have with running the selftests due to changes in the phy etc. Maybe you have just not received all those emails? Have you checked spamfilters? With the kernels now, I cannot even test with the software bridge and selftests as the compile fails - probably due to changes in uapi headers compared to what the packages my system uses expects.
