Re: [PATCH 052/117] media: rcar_fdp1: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Uwe Kleine-König (2023-03-26 15:31:19)
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/platform/renesas/rcar_fdp1.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar_fdp1.c b/drivers/media/platform/renesas/rcar_fdp1.c
> index 37ecf489d112..d80b3214dfae 100644
> --- a/drivers/media/platform/renesas/rcar_fdp1.c
> +++ b/drivers/media/platform/renesas/rcar_fdp1.c
> @@ -2396,7 +2396,7 @@ static int fdp1_probe(struct platform_device *pdev)
>         return ret;
>  }
>  
> -static int fdp1_remove(struct platform_device *pdev)
> +static void fdp1_remove(struct platform_device *pdev)
>  {
>         struct fdp1_dev *fdp1 = platform_get_drvdata(pdev);
>  
> @@ -2404,8 +2404,6 @@ static int fdp1_remove(struct platform_device *pdev)
>         video_unregister_device(&fdp1->vfd);
>         v4l2_device_unregister(&fdp1->v4l2_dev);
>         pm_runtime_disable(&pdev->dev);
> -
> -       return 0;
>  }
>  
>  static int __maybe_unused fdp1_pm_runtime_suspend(struct device *dev)
> @@ -2441,7 +2439,7 @@ MODULE_DEVICE_TABLE(of, fdp1_dt_ids);
>  
>  static struct platform_driver fdp1_pdrv = {
>         .probe          = fdp1_probe,
> -       .remove         = fdp1_remove,
> +       .remove_new     = fdp1_remove,
>         .driver         = {
>                 .name   = DRIVER_NAME,
>                 .of_match_table = fdp1_dt_ids,
> -- 
> 2.39.2
>




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux