Re: [PATCH net-next] sh_eth: remove open coded netif_running()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sergey Shtylyov <s.shtylyov@xxxxxx>
Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running()
From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Date: Mon, 27 Mar 2023 10:14:58 +0200
Cc: Jakub Kicinski <kuba@xxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <6d2f216c-df1d-9ab5-353c-de5e5e082b57@omp.ru>
Mail-followup-to: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, Sergey Shtylyov <s.shtylyov@xxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
References: <20230321065826.2044-1-wsa+renesas@sang-engineering.com> <79d945a4-e105-4bc4-3e73-64971731660e@omp.ru> <CAMuHMdUt_kTH3tnrdF=oKBLyjrstei8PLsyr+dFXVoPEyxTLAA@mail.gmail.com> <20230323094034.5b021c65@kernel.org> <6d2f216c-df1d-9ab5-353c-de5e5e082b57@omp.ru>

> > Nope - one is under rtnl_lock, the other under just RCU, IIRC.
> > So this patch just makes the race worse, but it was already
> > racy before.
> 
>    How about reverting it then?

Agreed. Will send a revert.

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH net-next] sh_eth: remove open coded netif_running()
  - From: Wolfram Sang
- Re: [PATCH net-next] sh_eth: remove open coded netif_running()
  - From: Sergey Shtylyov
- Re: [PATCH net-next] sh_eth: remove open coded netif_running()
  - From: Geert Uytterhoeven
- Re: [PATCH net-next] sh_eth: remove open coded netif_running()
  - From: Jakub Kicinski
- Re: [PATCH net-next] sh_eth: remove open coded netif_running()
  - From: Sergey Shtylyov

Prev by Date: Patchwork summary for: linux-renesas-soc
Next by Date: [PATCH] Revert "sh_eth: remove open coded netif_running()"
Previous by thread: Re: [PATCH net-next] sh_eth: remove open coded netif_running()
Next by thread: Re: [PATCH net-next] sh_eth: remove open coded netif_running()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]