Hi Morimoto-san, On Tue, Mar 7, 2023 at 12:49 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > These adds R-Car Sound support for WhiteHawk board using > ARD-AUDIO-DA7212 external audio board. > It is using DT overlay. > > Signed-off-by: Linh Phung <linh.phung.jy@xxxxxxxxxxx> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-ard-audio-da7212.dtso > +&{/} { > + sound_card: sound { > + compatible = "audio-graph-card"; > + label = "rcar-sound"; > + > + dais = <&rsnd_port0>; /* DA7212 Audio Codec */ > + }; > + > + tpu_clk: tpu_clk { Will rename to "tpu-clk" while applying, as underscores are not recommended in node names. > +&rcar_sound { > + pinctrl-0 = <&sound_clk_pins>, <&sound_pins>; > + pinctrl-names = "default"; > + > + /* Single DAI */ > + #sound-dai-cells = <0>; > + > + /* audio_clkout */ > + #clock-cells = <0>; > + clock-frequency = <5644800>; /* 44.1kHz groups [(C) clock] */ > +// clock-frequency = <6144000>; /* 48 kHz groups [(C) clock] */ > + > + status = "okay"; > + > + /* update <clkin> to <tpu_clk> */ > + clocks = <&cpg CPG_MOD 2926>, <&cpg CPG_MOD 2927>, <&tpu_clk>; > + > + ports { > + rsnd_port0: port { Will change to "rsnd_port:", as you dropped the @0. > + rsnd_endpoint: endpoint { > + remote-endpoint = <&da7212_endpoint>; > + > + dai-format = "i2s"; > + bitclock-master = <&rsnd_endpoint>; > + frame-master = <&rsnd_endpoint>; > + > + /* Please use exclusively to the 'capture' */ > + playback = <&ssi0>; > + /* [CAPTURE] */ > + /* capture = <&ssi0>; */ > + }; > + }; > + }; > +}; Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v6.4, with the above fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds