Hi Ralph, ralph.siemsen@xxxxxxxxxx wrote on Wed, 1 Mar 2023 16:55:20 -0500: > Each entry in the clock table specifies a number of individual bits in > registers, for contolling clock reset, gaiting, etc. These reg/bit were > packed into a u16 to save space. The combined value is difficult to > understand when reviewing the clock table entries. > > Introduce a "struct regbit" which still occupies only 16 bits, but > allows the register and bit values to be specified explicitly. Convert > all previous uses of u16 for reg/bit into "struct regbit". > > The bulk of this patch converts the clock table to use struct regbit, > making use of the RB() helper macro. The conversion was automated by > script, and as a further verification, the compiled binary of the table > was compared before/after the change (with objdump -D). > > The clk_rdesc_set() function now checks for zero reg/bit internally. > This allows callers of that function to remove those checks. > > Signed-off-by: Ralph Siemsen <ralph.siemsen@xxxxxxxxxx> Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> Thanks, Miquèl
