Hi Dan,
Thank you for the patch.
On Mon, Feb 27, 2023 at 01:06:59PM +0300, Dan Carpenter wrote:
> The drmm_encoder_alloc() function returns error pointers. It never
> returns NULL. Fix the check accordingly.
>
> Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder")
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> index b1787be31e92..7ecec7b04a8d 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c
> @@ -109,8 +109,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
> renc = drmm_encoder_alloc(&rcdu->ddev, struct rcar_du_encoder, base,
> &rcar_du_encoder_funcs, DRM_MODE_ENCODER_NONE,
> NULL);
> - if (!renc)
> - return -ENOMEM;
> + if (IS_ERR(renc))
> + return PTR_ERR(renc);
>
> renc->output = output;
>
--
Regards,
Laurent Pinchart
