Hello Wolfram-san,
> From: Wolfram Sang, Sent: Tuesday, January 24, 2023 4:47 PM
>
> Documentation says only DTDL of 200 is allowed for this SoC.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Best regards,
Yoshihiro Shimoda
> ---
>
> Tested with MSIOF0 on a Salvator-XS with R-Car H3 ES2.0 by creating a
> loopback with a wire.
>
> drivers/spi/spi-sh-msiof.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
> index 9bca3d076f05..609f48ec84dd 100644
> --- a/drivers/spi/spi-sh-msiof.c
> +++ b/drivers/spi/spi-sh-msiof.c
> @@ -30,12 +30,15 @@
>
> #include <asm/unaligned.h>
>
> +#define SH_MSIOF_FLAG_FIXED_DTDL_200 BIT(0)
> +
> struct sh_msiof_chipdata {
> u32 bits_per_word_mask;
> u16 tx_fifo_size;
> u16 rx_fifo_size;
> u16 ctlr_flags;
> u16 min_div_pow;
> + u32 flags;
> };
>
> struct sh_msiof_spi_priv {
> @@ -1073,6 +1076,16 @@ static const struct sh_msiof_chipdata rcar_gen3_data = {
> .min_div_pow = 1,
> };
>
> +static const struct sh_msiof_chipdata rcar_r8a7795_data = {
> + .bits_per_word_mask = SPI_BPW_MASK(8) | SPI_BPW_MASK(16) |
> + SPI_BPW_MASK(24) | SPI_BPW_MASK(32),
> + .tx_fifo_size = 64,
> + .rx_fifo_size = 64,
> + .ctlr_flags = SPI_CONTROLLER_MUST_TX,
> + .min_div_pow = 1,
> + .flags = SH_MSIOF_FLAG_FIXED_DTDL_200,
> +};
> +
> static const struct of_device_id sh_msiof_match[] = {
> { .compatible = "renesas,sh-mobile-msiof", .data = &sh_data },
> { .compatible = "renesas,msiof-r8a7743", .data = &rcar_gen2_data },
> @@ -1083,6 +1096,7 @@ static const struct of_device_id sh_msiof_match[] = {
> { .compatible = "renesas,msiof-r8a7793", .data = &rcar_gen2_data },
> { .compatible = "renesas,msiof-r8a7794", .data = &rcar_gen2_data },
> { .compatible = "renesas,rcar-gen2-msiof", .data = &rcar_gen2_data },
> + { .compatible = "renesas,msiof-r8a7795", .data = &rcar_r8a7795_data },
> { .compatible = "renesas,msiof-r8a7796", .data = &rcar_gen3_data },
> { .compatible = "renesas,rcar-gen3-msiof", .data = &rcar_gen3_data },
> { .compatible = "renesas,rcar-gen4-msiof", .data = &rcar_gen3_data },
> @@ -1280,6 +1294,9 @@ static int sh_msiof_spi_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> + if (chipdata->flags & SH_MSIOF_FLAG_FIXED_DTDL_200)
> + info->dtdl = 200;
> +
> if (info->mode == MSIOF_SPI_SLAVE)
> ctlr = spi_alloc_slave(&pdev->dev,
> sizeof(struct sh_msiof_spi_priv));
> --
> 2.30.2
