Hi Andy Shevchenko, Thanks for the feedback. > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> > Sent: Friday, February 10, 2023 4:49 PM > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Jiri Slaby > <jirislaby@xxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; linux- > serial@xxxxxxxxxxxxxxx; Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>; > linux-renesas-soc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 2/3] serial: 8250_em: Update RZ/V2M port type as > PORT_16750 > > On Fri, Feb 10, 2023 at 03:41:39PM +0000, Biju Das wrote: > > The UART IP found on RZ/V2M SoC is Register-compatible with the > > general-purpose 16750 UART chip. This patch updates RZ/V2M port type > > from 16550A->16750 and also enables 64-bytes fifo support. > > ... > > > +#include <linux/of_device.h> > > property.h OK. > > ... > > > + priv->info = of_device_get_match_data(dev); > > device_get_match_data() OK. > > ... > > With Ilpo's comment addressed this looks good! Will send next version with above addressed. Cheers, Biju
