Hi Ilpo,
Thanks for the feedback.
> Subject: Re: [PATCH v2 2/3] serial: 8250_em: Update RZ/V2M port type as
> PORT_16750
>
> On Fri, 10 Feb 2023, Biju Das wrote:
>
> > The UART IP found on RZ/V2M SoC is Register-compatible with the
> > general-purpose 16750 UART chip. This patch updates RZ/V2M port type
> > from 16550A->16750 and also enables 64-bytes fifo support.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v2:
> > * New patch
> > ---
> > drivers/tty/serial/8250/8250_em.c | 27 +++++++++++++++++++++++----
> > 1 file changed, 23 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/tty/serial/8250/8250_em.c
> > b/drivers/tty/serial/8250/8250_em.c
> > index b78c74755735..628a6846bfdc 100644
> > --- a/drivers/tty/serial/8250/8250_em.c
> > +++ b/drivers/tty/serial/8250/8250_em.c
> > @@ -9,6 +9,7 @@
> > #include <linux/io.h>
> > #include <linux/module.h>
> > #include <linux/mod_devicetable.h>
> > +#include <linux/of_device.h>
> > #include <linux/serial_8250.h>
> > #include <linux/serial_reg.h>
> > #include <linux/platform_device.h>
> > @@ -19,9 +20,15 @@
> > #define UART_DLL_EM 9
> > #define UART_DLM_EM 10
> >
> > +struct serial8250_em_hw_info {
> > + unsigned int type;
> > + upf_t flags;
> > +};
> > +
> > struct serial8250_em_priv {
> > struct clk *sclk;
> > int line;
> > + const struct serial8250_em_hw_info *info;
> > };
> >
> > static void serial8250_em_serial_out(struct uart_port *p, int offset,
> > int value) @@ -95,6 +102,7 @@ static int serial8250_em_probe(struct
> platform_device *pdev)
> > if (!priv)
> > return -ENOMEM;
> >
> > + priv->info = of_device_get_match_data(dev);
>
> On second thought, do you even need to store the info beyond .probe()?
OK, will use local variable instead.
Cheers,
Biju
