Hi Rob, On Thu, Feb 9, 2023 at 3:54 PM Rob Herring <robh@xxxxxxxxxx> wrote: > On Thu, 09 Feb 2023 22:34:40 +0900, Yoshihiro Shimoda wrote: > > Since R-Car Gen4 doens't have the main IPMMU IMSSTR register, update > > the renesas,ipmmu-main property which sets maxItems as 1. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > --- > > Changes from v2: > > https://lore.kernel.org/all/20230127140446.1728102-1-yoshihiro.shimoda.uh@xxxxxxxxxxx/ > > - Set maxItems to renesas,ipmmu-main if R-Car Gen4. > > > > Changes from v1: > > https://lore.kernel.org/all/20230123012940.1250879-1-yoshihiro.shimoda.uh@xxxxxxxxxxx/ > > - Change number of argument for R-Car Gen4 instead of "module id". > > On the discussion, using 'minItems' is a solution. But, it causes > > "too short" errors on dtbs_check. So, using "oneOf" instead. > > > > .../bindings/iommu/renesas,ipmmu-vmsa.yaml | 19 ++++++++++++++----- > > 1 file changed, 14 insertions(+), 5 deletions(-) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230209133440.2643228-1-yoshihiro.shimoda.uh@xxxxxxxxxxx > > > iommu@ee480000: renesas,ipmmu-main: [[40], [10]] is too long > arch/arm64/boot/dts/renesas/r8a779f0-spider.dtb This is expected, as we're changing the bindings to match the (updated) documentation, but haven't updated the DTS yet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds