Hi all, > Subject: [usb:usb-next 35/35] kismet: WARNING: unmet direct dependencies > detected for USB_RZV2M_USB3DRD when selected by USB_XHCI_RZV2M > > tree: > head: c52c9acc415eb6ff54f658492f8c53da0fc3528a > commit: c52c9acc415eb6ff54f658492f8c53da0fc3528a [35/35] xhci: host: Add > Renesas RZ/V2M SoC support > git remote add usb > git fetch --no-tags usb usb-next > git checkout c52c9acc415eb6ff54f658492f8c53da0fc3528a > # 1. reproduce by kismet > # install kmax per > kismet --linux-ksrc=linux --selectees CONFIG_USB_RZV2M_USB3DRD -- > selectors CONFIG_USB_XHCI_RZV2M -a=csky > # 2. reproduce by make > # save the config file to linux source tree > cd linux > make ARCH=csky olddefconfig > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > kismet warnings: (new ones prefixed by >>) > >> kismet: WARNING: unmet direct dependencies detected for USB_RZV2M_USB3DRD > when selected by USB_XHCI_RZV2M > .config:4492:warning: symbol value 'ONFIG_ARCH_MMAP_RND_BITS_MI' invalid > for ARCH_MMAP_RND_BITS > > WARNING: unmet direct dependencies detected for USB_RZV2M_USB3DRD > Depends on [n]: USB_SUPPORT [=y] && USB_GADGET [=n] && (ARCH_R9A09G011 > [=n] || COMPILE_TEST [=y]) > Selected by [y]: > - USB_XHCI_RZV2M [=y] && USB_SUPPORT [=y] && USB [=y] && USB_XHCI_HCD > [=y] && USB_XHCI_PLATFORM [=y] && (ARCH_R9A09G011 [=n] || COMPILE_TEST [=y]) I have investigated this issue, Just for testing, I have reverted Arnd's patch[1] and then done the below changes which is fixing unmet dependencies reported by the bot. Looks like USB_RZV2M_USB3DRD should depend upon both USB and USB_GADGET. Previously It depends only on USB_GADGET. Also the USB3DRD driver should be in "driver/usb/renesas_usb3drd" directory instead of "driver/usb/gadget/udc" as both HOST and device ctrlr need this driver. So not sure, 1) Use Arnd's patch for fixing this issue 2) Use the changes from [2] Or 3) Arnd's changes + changes from [2]. Please let me know. [2] diff --git a/drivers/usb/renesas_usb3drd/Kconfig b/drivers/usb/renesas_usb3drd/Kconfig new file mode 100644 index 000000000000..6205d815d283 --- /dev/null +++ b/drivers/usb/renesas_usb3drd/Kconfig @@ -0,0 +1,14 @@ +# SPDX-License-Identifier: GPL-2.0 + +config USB_RZV2M_USB3DRD + tristate 'Renesas USB3.1 DRD controller' + depends on (USB || USB_GADGET) + depends on ARCH_R9A09G011 || COMPILE_TEST + default USB_XHCI_RZV2M + default USB_RENESAS_USB3 + help + Renesas USB3.1 DRD controller is a USB DRD controller + that supports both host and device switching. + + Say "y" to link the driver statically, or "m" to build a + dynamically linked module called "rzv2m_usb3drd". [1] https://lore.kernel.org/linux-usb/OS0PR01MB592264B5D8BB98A1B2F759C086D39@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/#t Kismet results: (env_kmax) dasb@ree-du1sdd5:~/linux-next$ kismet --linux-ksrc=. --selectees CONFIG_USB_RZV2M_USB3DRD --selectors CONFIG_USB_XHCI_RZV2M -a=csky INFO: Computing the build system id for the Linux source.. INFO: Build system id: d48d1edf73bf INFO: Kismet will analyze the select constructs of the architecture "csky" for unmet direct dependency. INFO: All times reported are measured using Python's time.perf_counter() utility. INFO: Prefetching the architecture kclause formulas. [STEP 1/3] reading kextract file [STEP 1/3] finished reading kextract file [STEP 2/3] translated 15981/15981 configuration option dependencies [STEP 3/3] converted 16084/16084 constraints to smtlib2 format [STEP 3/3] pickling the map [STEP 3/3] done INFO: Architecture kclause formulas were loaded. (686.24sec) INFO: Identifying the select constructs. INFO: Identification of the select constructs was done in 0.02sec. 1 constructs were found. unmet safe due to syntactical pass: 0. alarms: 1. INFO: Doing optimized SAT pass for 1 constructs INFO: 18:33:24 Optimized SAT pass progress: 1/1 (%100). INFO: Optimized SAT test was done in 0.02sec. 1 constructs with alarms were checked. unmet safe due to optimized SAT test: 1. alarms: 0. INFO: Doing precise SAT pass for 0 constructs INFO: 18:33:24 Precise SAT pass progress: 0/0. INFO: Precise SAT test was done in 0.00sec. 0 constructs with alarms were checked. unmet safe due to precise SAT test: 0. alarms: 0. INFO: During precise SAT test, 0 models were generated. INFO: Skipping test case generation since there are no models to generate test cases for. INFO: Skipping verification since there are no test cases to verify. INFO: Writing the aggregated summary txt to "kismet_summary_csky.txt". INFO: Aggregated summary txt was written. INFO: Writing the summary csv to "kismet_summary_csky.csv". INFO: Summary csv was written. (env_kmax) dasb@ree-du1sdd5:~/linux-next$ cat kismet_summary_csky.txt = Overall analysis = Over 1 select constructs, unmet dependency analysis resulted in: 1 safe, 0 alarm. The analysis was done in 686.27 seconds. = Timing results (seconds) = Prefetch arch formulas : 686.24 Identify constructs : 0.02 Optimized SAT pass : 0.02 Precise SAT pass : 0.00 = Per-stage results = == Identification of select constructs & udd analysis through syntax == 1 select constructs identified in the architecture. 0 select constructs were found udd safe through syntax analysis. 1 select constructs were found udd alarm through syntax analysis. == Optimized SAT pass == 1 select constructs with alarms from the previous stage were checked during optimized SAT pass. 1 select constructs were found udd SAFE through optimized SAT pass. 0 select constructs were found udd ALARM through optimized SAT pass. == Precise SAT pass == 0 select constructs with alarms from the previous stage were checked during precise SAT pass. 0 select constructs were found udd SAFE through precise SAT pass. 0 select constructs were found udd ALARM through precise SAT pass. (env_kmax) dasb@ree-du1sdd5:~/linux-next$ cat kismet_summary_csky.csv arch,selectee,selector,visib_id,constraint_type,analysis_result,testcase csky,CONFIG_USB_RZV2M_USB3DRD,CONFIG_USB_XHCI_RZV2M,0,0,UNMET_SAFE_OPTIMIZED_PASS,N/A Cheers, Biju
