On Thu, 26 Jan 2023, Daniel Lezcano wrote: > On 13/01/2023 17:17, Biju Das wrote: > > [ ... ] > > > +config RZ_MTU3 > > + bool "Renesas RZ/G2L MTU3a core driver" > > + select MFD_CORE > > + depends on (ARCH_RZG2L && OF) || COMPILE_TEST > > + help > > + Select this option to enable Renesas RZ/G2L MTU3a core driver for > > + the Multi-Function Timer Pulse Unit 3 (MTU3a) hardware available > > + on SoCs from Renesas. The core driver shares the clk and channel > > + register access for the other child devices like Counter, PWM, > > + Clock Source, and Clock event. > > Do you really want to have this option manually selectable? Usually we try > to avoid that and keep a silent option which is selected by the platform > config. > > [ ... ] > > > + > > + ret = mfd_add_devices(&pdev->dev, 0, rz_mtu3_devs, > > + ARRAY_SIZE(rz_mtu3_devs), NULL, 0, NULL); > > + if (ret < 0) > > + goto err_assert; > > + > > + return devm_add_action_or_reset(&pdev->dev, rz_mtu3_reset_assert, > > + &pdev->dev); > > + > > +err_assert: > > + reset_control_assert(ddata->rstc); > > + return ret; > > +} > > I'm not sure this driver falls under the clocksource umbrella but under mfd > [cc'ed Lee Jones] Thanks Daniel. Please do not use the mfd_* API outside of drivers/mfd. If you require MFD functionality, write an MFD driver. -- Lee Jones [李琼斯]
