Hi Morimoto-san, On Thu, Jan 26, 2023 at 3:19 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > This patch adds module clocks for Audio (SSI/SSIU) blocks on > the Renesas R-Car V4H (R8A779G0) SoC. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thanks for your patch! > --- a/drivers/clk/renesas/r8a779g0-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a779g0-cpg-mssr.c > @@ -202,6 +202,8 @@ static const struct mssr_mod_clk r8a779g0_mod_clks[] __initconst = { > DEF_MOD("pfc1", 916, R8A779G0_CLK_CL16M), > DEF_MOD("pfc2", 917, R8A779G0_CLK_CL16M), > DEF_MOD("pfc3", 918, R8A779G0_CLK_CL16M), > + DEF_MOD("ssiu", 2926, R8A779G0_CLK_S0D6_PER), > + DEF_MOD("ssi", 2927, R8A779G0_CLK_S0D6_PER), LGTM, although I couldn't verify the parent clock. > }; Does this actually work as-is? The arrays in drivers/clk/renesas/renesas-cpg-mssr.c do not yet contain the register offsets for e.g. MSTPCR28 and beyond... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds