Hi Morimoto-san,
On Thu, Jan 19, 2023 at 2:52 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> "sydm" is bit name. Let's rename it as common "sys-dmac".
> This patch fixes the numbering, too.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> @@ -176,8 +176,8 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
> DEF_MOD("scif3", 704, R8A779A0_CLK_S1D8),
> DEF_MOD("scif4", 705, R8A779A0_CLK_S1D8),
> DEF_MOD("sdhi0", 706, R8A779A0_CLK_SD0),
> - DEF_MOD("sydm1", 709, R8A779A0_CLK_S1D2),
> - DEF_MOD("sydm2", 710, R8A779A0_CLK_S1D2),
> + DEF_MOD("sys-dmac0", 709, R8A779A0_CLK_S1D2),
> + DEF_MOD("sys-dmac1", 710, R8A779A0_CLK_S1D2),
Actually Rev 0.5 of the documentation does call the channels "SYS-DMAC1"
and "SYS-DMAC2".
Shall we use that numbering?
We also have labels "dmac1" and "dmac2" in DTS.
> DEF_MOD("tmu0", 713, R8A779A0_CLK_CL16MCK),
> DEF_MOD("tmu1", 714, R8A779A0_CLK_S1D4),
> DEF_MOD("tmu2", 715, R8A779A0_CLK_S1D4),
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
