On Mon, Jan 23, 2023 at 07:56:02PM +0100, Geert Uytterhoeven wrote: > Hi all, > > This patch series adds support for the CAN-FD interface on the Renesas > R-Car V4H (R8A779G0) SoC and support for CAN transceivers described as > PHYs to the R-Car CAN-FD driver. It includes several fixes for issues > (some minor) detected while adding the support and during testing. > More details can be found in the individual patches. > > Note that the last patch depends on "[PATCH 1/7] phy: Add > devm_of_phy_optional_get() helper"[1]. > > This has been tested on the Renesas White-Hawk development board using > cansend, candump, and canfdtest: > - Channel 0 uses an NXP TJR1443AT CAN transceiver, and works fine, > - Channels 1-7 use Microchip MCP2558FD-H/SN CAN transceivers (not > mounted for channels 4-7), which do not need explicit description. > While channel 1 works fine, channels 2-3 do not seem to work. > > Hence despite the new fixes, the test results are similar to what Ulrich > Hecht reported for R-Car V3U on the Falcon development board before, > i.e. only channels 0 and 1 work (FTR, [2] does not help). > Whether this is a CAN-FD driver issue, a pin control issue, an IP core > issue, or an SoC integration issue is still to be seen... > > > Thanks for your comments! FWIIW this series looks clean to me: Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
