On Sat, Jan 21, 2023 at 09:59:53AM +0000, Biju Das wrote: > Hi Greg, > > Thanks for the feedback. > > > Subject: Re: [PATCH v2 00/12] ADD USB3.1 HOST, Peri and DRD support > > > > On Thu, Jan 12, 2023 at 09:58:54PM +0000, Biju Das wrote: > > > This patch series aims to add USB3.1 HOST, Peri and DRD support on > > > RZ/V2M EVK platform. > > > > > > The reset for both host and peri are located in USB3DRD block. The > > > USB3DRD registers are mapped in the AXI address space of the > > > Peripheral module. > > > > > > RZ/V2M XHCI is similar to R-Car XHCI but it doesn't require any > > > firmware. > > > > > > Host/device needs to do reset release and set the host/device function > > > on DRD module, before accessing any registers. > > > > After applying this series and building it on x86_64 I get the following > > build errors: > > > > ERROR: modpost: "rzv2m_usb3drd_reset" [drivers/usb/host/xhci-plat-hcd.ko] > > undefined! > > ERROR: modpost: "rzv2m_usb3drd_reset" > > [drivers/usb/gadget/udc/renesas_usb3.ko] undefined! > > The file drivers/usb/gadget/udc/rzv2m_usb3drd.c is not getting compiled, > > If USB_RZV2M_USB3DRD=y, USB_XHCI_RZV2M=m and USB_RENESAS_USB3=m and > Because of that modpost is giving undefined error. > > So I have updated the KCONFIG like below and now it builds OK now. I will send next version > based on this, if there are no comments. > > -- a/drivers/usb/gadget/udc/Kconfig > +++ b/drivers/usb/gadget/udc/Kconfig > @@ -180,10 +180,17 @@ config USB_RENESAS_USBHS_UDC > gadget drivers to also be dynamically linked. > > config USB_RZV2M_USB3DRD > + tristate 'Renesas USB3.1 DRD controller' > depends on ARCH_R9A09G011 || COMPILE_TEST > - bool > - default y if USB_XHCI_RZV2M > - default y if USB_RENESAS_USB3 > + default y if USB_XHCI_RZV2M=y > + default y if USB_RENESAS_USB3=y These should just be: default USB_XHCI_RZV2M default USB_RENESAS_USB3 right? thanks, greg k-h
