Hi Geert-san, > From: Geert Uytterhoeven, Sent: Thursday, January 12, 2023 7:31 PM > > Hi Shimoda-san, > > On Thu, Jan 12, 2023 at 9:02 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > > From: Geert Uytterhoeven, Sent: Thursday, January 12, 2023 1:20 AM > > > On Thu, Dec 22, 2022 at 10:33 AM Yoshihiro Shimoda > > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > > > Enable UFS device for R-Car S4-8 Spider CPU board. > > > > > > > > Note that the conditions of RC21012 on the Spider are: > > > > - OUT11 (for UFS30_REFCLK_V) is disabled as default. > > > > - OUT11 is controlled by GPIO0 pin. > > > > - The GPIO0 pin is inverted sense (low active) and pull-up enabled. > > > > > To output the clock, pin 4 of TCA9554 on the Spider board needs to > > > > output low level so that using "gpio-gate-clock" for it. > > > > > > Does this mean the GPIO setup was the only missing part, > > > and the i2c commands from [1] were not needed? > > > > You're correct. > > > > > I wanted to give this a try, but the remote Spider is offline. > > The remote Spider access issue was fixed, and the three > UFS subdevices are detected fine. > Hdparm says 280 MB/s (compared to 170 for eMMC). > > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thank you for the test! I'll send v2 patch soon. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds