Hi Morimoto-san,
On Wed, Dec 14, 2022 at 2:48 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> ALSA SoC has many type of Generic Audio Card driver (Simple Audio Card,
> Audio Graph Card, Audio Graph Card2), and Renesas/Kuninori Morimoto want
> to test these.
>
> Generic Audio Card driver had been requested on ALSA SoC.
> It has many type of device connection method, and historically,
> requested connection support range of generic driver have been
> upgraded.
>
> Upgrading connection support range itself was possible on generic
> driver, but could not implemented, because we need to keep compatibility
> on Device-Tree. This is one of the reason why we have many type of
> Generic Audio Card driver.
>
> ULCB/KF is good board to test these.
> Kuninori has been testing these Generic Audio Card driver by using his
> local patch to switching drivers. But it is good idea to upstream these
> from information sharing point of view, because DT setting is complex.
> It can be good sample for user. This patch is one of them.
>
> From normal user point of view who don't need to test the driver,
> it should keep as-is, nothing changed.
>
> This patch adds "Simle Audio Card" DT setting file for ULCB/KF.
> We can switch to use it if ulcb.dtsi / ulcb-kf.dtsi were updated.
>
> Because it needs "switching driver", not "add extra feature",
> it doesn't use Device-Tree overlay.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Thanks for your patch!
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf-simple-audio-card.dtsi
> @@ -0,0 +1,85 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device Tree for ULCB + Kingfisher + Simple Audio Card
> + *
> + * Copyright (C) 2022 Renesas Electronics Corp.
> + */
> +
> +/*
> + * (A) CPU0 ------ ak4613
> + * (B) CPU1 ------ HDMI
> + * (C) CPU2 ------ PCM3168A-p
> + * (D) CPU3 ------ PCM3168A-c
> + *
> + * (A) aplay -D plughw:0,0 xxx.wav
> + * (B) aplay -D plughw:0,1 xxx.wav
> + * (C) aplay -D plughw:0,2 xxx.wav
> + *
> + * (A) arecord -D plughw:0,0 xxx.wav
> + * (D) arecord -D plughw:0,3 xxx.wav
> + */
> +
> +&sound_card {
> + /* dai-link@0/1 are defined in ulcb.dtsi */
> +
> + /*
> + * (C) CPU2 <-> PCM3168A-p
"->", as this is used for playback only (everywhere, in all patches).
> +&rcar_sound {
> +
> + /* dai0-1 are defined in ulcb.dtsi */
I think this comment belongs under "rcar_sound,dai" below.
> +
> + rcar_sound,dai {
> + /*
> + * (C) CPU2 <-> PCM3168A-p
> + */
> + dai2 {
> + playback = <&ssi3>;
> + };
> + /*
> + * (D) CPU3 <-> PCM3168A-c
> + */
> + dai3 {
> + capture = <&ssi4>;
> + };
> + };
> +};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
