Hi Jakub, > From: Jakub Kicinski, Sent: Thursday, January 12, 2023 1:19 PM > > On Tue, 10 Jan 2023 18:55:59 +0900 Yoshihiro Shimoda wrote: > > +#define rswitch_for_each_enabled_port_reverse(priv, i) \ > > + for (i--; i >= 0; i--) \ > > nit: the typical name suffix for this sort of macro in Linux would > be _continue_reverse - because it doesn't initialize the iterator. > It's specifically targeting error paths. > > That's what list.h uses, on a quick grep I can see the same convention > is used for netdevice.h and dsa.h. Do you have counter examples? > I reckon we should throw "_continue" into the name. Thank you for your comments! I didn't know suffix "__continue_" on macros. So, I will rename this macro name with rswitch_for_each_enabled_port_continue_reverse(). Best regards, Yoshihiro Shimoda
