Hi Yoshihiro,
On Tue, 2023-01-10 at 14:02 +0900, Yoshihiro Shimoda wrote:
> Simplify struct phy *serdes handling by keeping the valiable in
> the struct rswitch_device.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> ---
> drivers/net/ethernet/renesas/rswitch.c | 40 ++++++++++++----------
> ----
> drivers/net/ethernet/renesas/rswitch.h | 1 +
> 2 files changed, 19 insertions(+), 22 deletions(-)
>
>
>
> -static int rswitch_serdes_set_params(struct rswitch_device *rdev)
>
>
> static int rswitch_ether_port_init_one(struct rswitch_device *rdev)
> @@ -1299,6 +1290,10 @@ static int rswitch_ether_port_init_one(struct
> rswitch_device *rdev)
> if (err < 0)
> goto err_phylink_init;
>
> + err = rswitch_serdes_phy_get(rdev);
> + if (err < 0)
> + goto err_serdes_phy_get;
I think, we can use *err_serdes_set_params* instead of creating new
label err_serdes_phy_get, since the label is not doing any work.
> +
> err = rswitch_serdes_set_params(rdev);
> if (err < 0)
> goto err_serdes_set_params;
> @@ -1306,6 +1301,7 @@ static int rswitch_ether_port_init_one(struct
> rswitch_device *rdev)
> return 0;
>
> err_serdes_set_params:
> +err_serdes_phy_get:
> rswitch_phylink_deinit(rdev);
>
> err_phylink_init:
> diff --git a/drivers/net/ethernet/renesas/rswitch.h
> b/drivers/net/ethernet/renesas/rswitch.h
> index edbdd1b98d3d..d9a0be6666f5 100644
> --- a/drivers/net/ethernet/renesas/rswitch.h
> +++ b/drivers/net/ethernet/renesas/rswitch.h
> @@ -941,6 +941,7 @@ struct rswitch_device {
>
> int port;
> struct rswitch_etha *etha;
> + struct phy *serdes;
> };
>
> struct rswitch_mfwd_mac_table_entry {
