Hi Michael, Thanks for picking this up! On Wed, Dec 28, 2022 at 12:07:19AM +0100, Michael Walle wrote: > + if (!bus || !bus->name) > + return -EINVAL; > + > + /* An access method always needs both read and write operations */ > + if ((bus->read && !bus->write) || > + (!bus->read && bus->write) || > + (bus->read_c45 && !bus->write_c45) || > + (!bus->read_c45 && bus->write_c45)) I wonder whether the following would be even more readable: if (!bus->read != !bus->write || !bus->read_c45 != !bus->write_c45) which essentially asserts that the boolean of !method for the read and write methods must match. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
