Hi Conor, Thank you for the review. On Sat, Dec 17, 2022 at 8:52 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > Hey Prabhakar, > > On Mon, Dec 12, 2022 at 11:55:03AM +0000, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Pass direction and operation to ALT_CMO_OP() macro. > > > > Vendors might want to perform different operations based on the direction > > and callbacks (arch_sync_dma_for_device/arch_sync_dma_for_cpu/ > > arch_dma_prep_coherent) so to handle such cases pass the direction and > > operation to ALT_CMO_OP() macro. This is in preparation for adding errata > > for the Andes CPU core. > > This patch seems to break the build on top of the most recent > linux-next: > ......./stuff/linux/arch/riscv/mm/pmem.c:13:53: error: too few arguments provided to function-like macro invocation > ALT_CMO_OP(clean, addr, size, riscv_cbom_block_size); > ^ > /stuff/linux/arch/riscv/include/asm/errata_list.h:127:9: note: macro 'ALT_CMO_OP' defined here > #define ALT_CMO_OP(_op, _start, _size, _cachesize, _dir, _ops) \ > ^ > .. CC block/partitions/sgi.o > .+...+/stuff/linux/arch/riscv/mm/pmem.c:13:2: error: use of undeclared identifier 'ALT_CMO_OP' > ALT_CMO_OP(clean, addr, size, riscv_cbom_block_size); > ^ > /stuff/linux/arch/riscv/mm/pmem.c:19:53: error: too few arguments provided to function-like macro invocation > ALT_CMO_OP(inval, addr, size, riscv_cbom_block_size); > ^ > /stuff/linux/arch/riscv/include/asm/errata_list.h:127:9: note: macro 'ALT_CMO_OP' defined here > #define ALT_CMO_OP(_op, _start, _size, _cachesize, _dir, _ops) \ > ^ > ........... AR lib/math/built-in.a > ./stuff/linux/arch/riscv/mm/pmem.c:19:2: .error: use of undeclared identifier 'ALT_CMO_OP' > ALT_CMO_OP(inval, addr, size, riscv_cbom_block_size); > ^ > ..4 errors generated. > > The pmem stuff is new so that'd be why it has not come up before. > > (FWIW, clang allmodconfig) > Yes I need to rebase my changes on Palmer's branch. Cheers, Prabhakar
