On Tue, Dec 13, 2022 at 10:43:08PM +0000, Fabrizio Castro wrote: > The RZ/V2M PWC is a multi-function device, and its software > support relies on "syscon" and "simple-mfd". > Add the dt-bindings for the top level device tree node. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > --- > .../bindings/mfd/renesas,rzv2m-pwc.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/renesas,rzv2m-pwc.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/renesas,rzv2m-pwc.yaml b/Documentation/devicetree/bindings/mfd/renesas,rzv2m-pwc.yaml > new file mode 100644 > index 000000000000..a7e180bfbd83 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/renesas,rzv2m-pwc.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/renesas,rzv2m-pwc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/V2M External Power Sequence Controller (PWC) > + > +description: |+ > + The PWC IP found in the RZ/V2M family of chips comes with the below > + capabilities > + - external power supply on/off sequence generation > + - on/off signal generation for the LPDDR4 core power supply (LPVDD) > + - key input signals processing > + - general-purpose output pins > + > +maintainers: > + - Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r9a09g011-pwc # RZ/V2M > + - renesas,r9a09g055-pwc # RZ/V2MA > + - const: renesas,rzv2m-pwc > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + gpio: > + type: object > + $ref: /schemas/gpio/renesas,rzv2m-pwc-gpio.yaml# > + description: General-Purpose Output pins controller. > + > + poweroff: > + type: object > + $ref: /schemas/power/reset/renesas,rzv2m-pwc-poweroff.yaml# > + description: Power OFF controller. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pwc: pwc@a3700000 { > + compatible = "renesas,r9a09g011-pwc", "renesas,rzv2m-pwc", "syscon", > + "simple-mfd"; > + reg = <0xa3700000 0x800>; > + > + gpio { > + compatible = "renesas,r9a09g011-pwc-gpio", > + "renesas,rzv2m-pwc-gpio"; > + regmap = <&pwc>; > + offset = <0x80>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + poweroff { > + compatible = "renesas,r9a09g011-pwc-poweroff", > + "renesas,rzv2m-pwc-poweroff"; > + regmap = <&pwc>; Why does this need to be a child node? There aren't any resources for it. 'regmap' is just the parent node. Assuming this binding is complete, I don't think you need any child nodes. A single node can have multiple providers. Rob