On 02/12/2022 13:55, Geert Uytterhoeven wrote:
> Convert the Texas Instruments PCM3168A Audio Codec Device Tree binding
> documentation to json-schema.
>
> Add missing properties.
> Drop unneeded pinctrl properties from example.
Thank you for your patch. There is something to discuss/improve.
> +description:
> + The Texas Instruments PCM3168A is a 24-bit Multi-channel Audio CODEC with
> + 96/192kHz sampling rate, supporting both SPI and I2C bus access.
> +
> +properties:
> + compatible:
> + const: ti,pcm3168a
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: System clock input
> +
> + clock-names:
> + items:
> + - const: scki
> +
> + reset-gpios:
> + items:
> + - description: |
> + GPIO line connected to the active-low RST pin of the codec.
> + RST = low: device power-down
> + RST = high: device is enabled
> +
> + "#sound-dai-cells":
> + enum: [0, 1]
This is a bit unexpected. Looking at DTSes:
1. I see in ulcb-kf.dtsi with cells==0, but two endpoints. The dai cells
seem unused? In such case shall dai-cells be skipped if we have endpoints?
2. in k3-j721e-common-proc-board.dts has cells=1, but user's phandle
does not have an argument, so practically it is ==0? The user -
sound/soc/ti/j721e-evm.c - just gets the node and does not use cells,
right? So even though dai-cells==1, it does not matter, because user
gets its own parsing?
3. The pcm3168a driver also does not have any xlate function, but it
registers to DAIs, so all uses should be with cells==1 to select proper
DAI...
> +
> + VDD1-supply:
> + description: Digital power supply regulator 1 (+3.3V)
> +
> + VDD2-supply:
> + description: Digital power supply regulator 2 (+3.3V)
> +
> + VCCAD1-supply:
> + description: ADC power supply regulator 1 (+5V)
> +
> + VCCAD2-supply:
> + description: ADC power supply regulator 2 (+5V)
> +
> + VCCDA1-supply:
> + description: DAC power supply regulator 1 (+5V)
> +
> + VCCDA2-supply:
> + description: DAC power supply regulator 2 (+5V)
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + properties:
> + port@0:
> + $ref: audio-graph-port.yaml#
> + description: Audio input port.
unevaluatedProperties: false
> +
> + port@1:
> + $ref: audio-graph-port.yaml#
> + description: Audio output port.
unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - VDD1-supply
> + - VDD2-supply
> + - VCCAD1-supply
> + - VCCAD2-supply
> + - VCCDA1-supply
> + - VCCDA2-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pcm3168a: audio-codec@44 {
> + compatible = "ti,pcm3168a";
> + reg = <0x44>;
> + reset-gpios = <&gpio0 4 GPIO_ACTIVE_LOW>;
> + clocks = <&clk_core 42>;
> + clock-names = "scki";
> + VDD1-supply = <&supply3v3>;
> + VDD2-supply = <&supply3v3>;
> + VCCAD1-supply = <&supply5v0>;
> + VCCAD2-supply = <&supply5v0>;
> + VCCDA1-supply = <&supply5v0>;
> + VCCDA2-supply = <&supply5v0>;
Can you extend the example with dai cells or with endpoints (or both,
depending on my previous comment...)
> + };
> + };
Best regards,
Krzysztof
