Hi Wolfram,
On Sat, 19 Nov 2022 22:56:46 +0100, Wolfram Sang wrote:
> Original motivation was to add I2C_FUNC_SLAVE, so users can easily
> find out if their hardware supports being a target. While here, add
> HostNotify and 10-bit addressing as well.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Fine with me, with one request below.
> ---
>
> Now, we could also add PROTOCOL_MANGLING and NO_START to have them all.
> But I am not sure if they are really helpful for users?
>
> tools/i2cdetect.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/i2cdetect.c b/tools/i2cdetect.c
> index 066ec82..54b78e2 100644
> --- a/tools/i2cdetect.c
> +++ b/tools/i2cdetect.c
> @@ -160,6 +160,12 @@ static const struct func all_func[] = {
> .name = "I2C Block Write" },
> { .value = I2C_FUNC_SMBUS_READ_I2C_BLOCK,
> .name = "I2C Block Read" },
> + { .value = I2C_FUNC_SMBUS_HOST_NOTIFY,
> + .name = "SMBus HostNotify" },
I'm not a big fan of gluing words. "SMBus Host Notify" please.
> + { .value = I2C_FUNC_10BIT_ADDR,
> + .name = "10-bit addressing" },
> + { .value = I2C_FUNC_SLAVE,
> + .name = "Target mode" },
> { .value = 0, .name = "" }
> };
>
Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
Thanks,
--
Jean Delvare
SUSE L3 Support
