Hi Yue, On Fri, Nov 18, 2022 at 7:36 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > rswitch_reg_wait() may return negative value, which converts to true later. > However rswitch_etha_hw_init() only check it less than zero. > > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"") > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> Thanks for your patch! A similar patch was already applied as https://git.kernel.org/netdev/net-next/c/b4b221bd79a1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds