Hi Dan,
> From: Dan Carpenter, Sent: Tuesday, November 15, 2022 10:10 PM
>
> The rswitch_etha_wait_link_verification() is supposed to return zero
> on success or negative error codes. Unfortunately it is declared as a
> bool so the caller treats everything as success.
>
> Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Best regards,
Yoshihiro Shimoda
> ---
> drivers/net/ethernet/renesas/rswitch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index f0168fedfef9..231e8c688b89 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -920,7 +920,7 @@ static void rswitch_etha_write_mac_address(struct rswitch_etha *etha, const u8 *
> etha->addr + MRMAC1);
> }
>
> -static bool rswitch_etha_wait_link_verification(struct rswitch_etha *etha)
> +static int rswitch_etha_wait_link_verification(struct rswitch_etha *etha)
> {
> iowrite32(MLVC_PLV, etha->addr + MLVC);
>
> --
> 2.35.1
