Hi Krzysztof, On Tue, 15 Nov 2022 14:16:27 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 14/11/2022 12:15, Herve Codina wrote: > > Add the USBF controller available in the r9a06g032 SoC. > > > > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx> > > --- > > arch/arm/boot/dts/r9a06g032.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi > > index 563024c9a4ae..a4bb069457a3 100644 > > --- a/arch/arm/boot/dts/r9a06g032.dtsi > > +++ b/arch/arm/boot/dts/r9a06g032.dtsi > > @@ -117,6 +117,18 @@ dmamux: dma-router@a0 { > > }; > > }; > > > > + udc: usb@4001e000 { > > + compatible = "renesas,r9a06g032-usbf", "renesas,rzn1-usbf"; > > + reg = <0x4001e000 0x2000>; > > + interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&sysctrl R9A06G032_HCLK_USBF>, > > + <&sysctrl R9A06G032_HCLK_USBPM>; > > + clock-names = "hclkf", "hclkpm"; > > + power-domains = <&sysctrl>; > > + status = "disabled"; > > If you provided all resources (clocks, power domains etc), why disabling it? Because I forgot to remove the 'status' property ... 'status' will be simply removed in v3. Sorry for this mistake. Thanks for the review, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com