[bug report] net: ethernet: renesas: Add support for "Ethernet Switch"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Yoshihiro Shimoda,

The patch 3590918b5d07: "net: ethernet: renesas: Add support for
"Ethernet Switch"" from Oct 31, 2022, leads to the following Smatch
static checker warning:

	drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init()
	warn: '%pM' cannot be followed by 'n'

drivers/net/ethernet/renesas/rswitch.c
    1706 
    1707         for (i = 0; i < RSWITCH_NUM_PORTS; i++) {
    1708                 err = register_netdev(priv->rdev[i]->ndev);
    1709                 if (err) {
    1710                         for (i--; i >= 0; i--)
    1711                                 unregister_netdev(priv->rdev[i]->ndev);
    1712                         goto err_register_netdev;
    1713                 }
    1714         }
    1715 
    1716         for (i = 0; i < RSWITCH_NUM_PORTS; i++)
--> 1717                 netdev_info(priv->rdev[i]->ndev, "MAC address %pMn",
                                                                          ^
This 'n' doesn't make sense.  See mac_address_string() for more details.

    1718                             priv->rdev[i]->ndev->dev_addr);
    1719 
    1720         return 0;
    1721 
    1722 err_register_netdev:
    1723         rswitch_ether_port_deinit_all(priv);
    1724 
    1725 err_ether_port_init_all:
    1726         rswitch_gwca_hw_deinit(priv);
    1727 
    1728 err_gwca_hw_init:
    1729 err_gwca_request_irq:
    1730         rcar_gen4_ptp_unregister(priv->ptp_priv);
    1731 
    1732 err_ptp_register:
    1733         for (i = 0; i < RSWITCH_NUM_PORTS; i++)
    1734                 rswitch_device_free(priv, i);
    1735 
    1736 err_device_alloc:
    1737         rswitch_gwca_desc_free(priv);
    1738 
    1739         return err;
    1740 }

regards,
dan carpenter




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux