Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Tuesday, November 15, 2022 12:55 AM
>
> Hi Shimoda-san,
>
> On Thu, Nov 10, 2022 at 2:16 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Add Ethernet Switch and SERDES nodes into R-Car S4-8 (r8a779f0).
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Thanks for your patch!
>
> LGTM, but...
>
> > --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
>
> > @@ -651,6 +661,105 @@ ufs: ufs@e6860000 {
> > status = "disabled";
> > };
> >
> > + rswitch: ethernet@e6880000 {
> > + compatible = "renesas,r8a779f0-ether-switch";
> > + reg = <0 0xe6880000 0 0x20000>, <0 0xe68c0000 0 0x20000>;
> > + reg-names = "base", "secure_base";
> > + interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 257 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 258 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 259 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 260 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 271 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 273 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 276 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 277 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 284 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 285 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 291 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 292 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 294 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 295 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 296 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 297 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 301 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 302 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 304 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "mfwd_error", "race_error",
> > + "coma_error", "gwca0_error",
> > + "gwca1_error", "etha0_error",
> > + "etha1_error", "etha2_error",
> > + "gptp0_status", "gptp1_status",
> > + "mfwd_status", "race_status",
> > + "coma_status", "gwca0_status",
> > + "gwca1_status", "etha0_status",
> > + "etha1_status", "etha2_status",
> > + "rmac0_status", "rmac1_status",
> > + "rmac2_status",
> > + "gwca0_rxtx0", "gwca0_rxtx1",
> > + "gwca0_rxtx2", "gwca0_rxtx3",
> > + "gwca0_rxtx4", "gwca0_rxtx5",
> > + "gwca0_rxtx6", "gwca0_rxtx7",
> > + "gwca1_rxtx0", "gwca1_rxtx1",
> > + "gwca1_rxtx2", "gwca1_rxtx3",
> > + "gwca1_rxtx4", "gwca1_rxtx5",
> > + "gwca1_rxtx6", "gwca1_rxtx7",
> > + "gwca0_rxts0", "gwca0_rxts1",
> > + "gwca1_rxts0", "gwca1_rxts1",
> > + "rmac0_mdio", "rmac1_mdio",
> > + "rmac2_mdio",
> > + "rmac0_phy", "rmac1_phy",
> > + "rmac2_phy";
> > + clocks = <&cpg CPG_MOD 1505>;
> > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
> > + resets = <&cpg 1505>;
> > + status = "disabled";
> > +
> > + ethernet-ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> ... please insert a blank line between properties and subnodes.
Thank you for your review! I got it. I'll fix it.
> > + port@0 {
> > + reg = <0>;
> > + phys = <ð_serdes 0>;
> > + };
> > + port@1 {
> > + reg = <1>;
> > + phys = <ð_serdes 1>;
> > + };
> > + port@2 {
> > + reg = <2>;
> > + phys = <ð_serdes 2>;
> > + };
> > + };
> > + };
> > +
> > scif0: serial@e6e60000 {
> > compatible = "renesas,scif-r8a779f0",
> > "renesas,rcar-gen4-scif", "renesas,scif";
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thanks!
Best regards,
Yoshihiro Shimoda
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
