On Mon, Nov 7, 2022 at 5:50 PM Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> wrote: > The preferred form for Renesas' compatible strings is: > "<vendor>,<family>-<module>" > > Somehow the compatible string for the r9a09g011 I2C IP was upstreamed > as renesas,i2c-r9a09g011 instead of renesas,r9a09g011-i2c, which > is really confusing, especially considering the generic fallback > is renesas,rzv2m-i2c. > > The first user of renesas,i2c-r9a09g011 in the kernel is not yet in > a kernel release, it will be in v6.1, therefore it can still be > fixed in v6.1. > Even if we don't fix it before v6.2, I don't think there is any > harm in making such a change. > > s/renesas,i2c-r9a09g011/renesas,r9a09g011-i2c/g for consistency. > > Fixes: 54ac6794df9d ("arm64: dts: renesas: r9a09g011: Add i2c nodes") > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > --- > > v2 - Improved changelog, as suggested by Geert and Krzysztof Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v6.2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds