On Fri, Nov 04, 2022 at 11:03:13AM +0800, Yang Li wrote: > diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > index c007e33c47e1..37f7359678e5 100644 > --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > @@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = { > static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > { > struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp); > - bool neg_adj = scaled_ppm < 0 ? true : false; > + bool neg_adj = scaled_ppm < 0; > s64 addend = ptp_priv->default_addend; > s64 diff; Please preserve reverse Christmas tree order. Thanks, Richard