Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v3 4/6] can: rcar_canfd: Add postdiv to struct
> rcar_canfd_hw_info
>
> Hi Biju,
>
> On Thu, Oct 27, 2022 at 10:22 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > R-Car has a clock divider for CAN FD clock within the IP, whereas it
> > is not available on RZ/G2L.
> >
> > Add postdiv variable to struct rcar_canfd_hw_info to take care of
> this
> > difference.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v2->v3:
> > * Replaced data type of postdiv from unsigned int->u8 to save
> memory.
>
> Thanks for the update!
>
> > --- a/drivers/net/can/rcar/rcar_canfd.c
> > +++ b/drivers/net/can/rcar/rcar_canfd.c
> > @@ -1943,9 +1947,9 @@ static int rcar_canfd_probe(struct
> platform_device *pdev)
> > }
> > fcan_freq = clk_get_rate(gpriv->can_clk);
> >
> > - if (gpriv->fcan == RCANFD_CANFDCLK && info->chip_id !=
> RENESAS_RZG2L)
> > + if (gpriv->fcan == RCANFD_CANFDCLK)
> > /* CANFD clock is further divided by (1/2) within
> the
> > IP */
>
> may be further divided?
Yes, It make sense. Will send v4 with this change.
/* CANFD clock may be further divided by (1/2) within the IP */
Cheers,
Biju
>
> > - fcan_freq /= 2;
> > + fcan_freq /= info->postdiv;
> >
> > addr = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(addr)) {
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a
> hacker. But when I'm talking to journalists I just say "programmer" or
> something like that.
> -- Linus Torvalds
