Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v4 4/4] mfd: Add RZ/G2L MTU3 PWM driver > > Hi Biju, > > On Mon, Oct 10, 2022 at 4:52 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > Add support for RZ/G2L MTU3 PWM driver. The IP supports following > PWM > > modes > > > > 1) PWM mode{1,2} > > 2) Reset-synchronized PWM mode > > 3) Complementary PWM mode{1,2,3} > > > > This patch adds basic pwm mode 1 support for RZ/G2L MTU3 driver by > > creating separate logical channels for each IOs. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -1994,6 +1994,12 @@ config MFD_RZ_MTU3_CNT > > SoCs. This IP supports both 16-bit and 32-bit phase > counting mode > > support. > > > > +config MFD_RZ_MTU3_PWM > > + tristate "Renesas RZ/G2L MTU3 PWM Timer support" > > + depends on MFD_RZ_MTU3 > > depends on PWM || COMPILE_TEST OK, this will move to PWM as the core is going to be part of timer bindings And pwm device is instantiated using mfd_add_device() > > Note that currently the build fails if CONFIG_PWM=n. > I have sent a patch to fix that > "[PATCH] pwm: Add missing dummy for devm_pwmchip_add()". OK, looks currently no one outside pwm subsystem is accessing this function. Cheers, Biju > > > + help > > + Enable support for RZ/G2L MTU3 PWM Timer controller. > > + > > config MFD_STM32_LPTIMER > > tristate "Support for STM32 Low-Power Timer" > > depends on (ARCH_STM32 && OF) || COMPILE_TEST > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a > hacker. But when I'm talking to journalists I just say "programmer" or > something like that. > -- Linus Torvalds