RE: [PATCH v4 3/4] mfd: Add RZ/G2L MTU3 counter driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH v4 3/4] mfd: Add RZ/G2L MTU3 counter driver
> 
> Hi Biju,
> 
> On Mon, Oct 10, 2022 at 4:53 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Add RZ/G2L MTU3 counter driver. This IP supports the following phase
> > counting modes on MTU1 and MTU2 channels
> >
> > 1) 16-bit phase counting modes on MTU1 and MTU2 channels.
> > 2) 32-bit phase counting mode by cascading MTU1 and MTU2.
> >
> > This patch adds 3 counters by creating 3 logical channels
> >         counter0: 16-bit phase counter on MTU1 channel
> >         counter1: 16-bit phase counter on MTU2 channel
> >         counter2: 32-bit phase counter by cascading MTU1 and MTU2
> >                   channels.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1986,6 +1986,14 @@ config MFD_RZ_MTU3
> >           To compile this driver as a module, choose M here: the
> >           module will be called rz-mtu3.
> >
> > +config MFD_RZ_MTU3_CNT
> > +       tristate "RZ/G2L MTU3 counter driver"
> 
> "depends on COUNTER", else it fails to link.

OK, will add this dependency in counter/Kconfig.

As pwm/counter maintainers agreed to move the core to timer bindings.
and instantiate child devices using mfd_add_device().

Cheers,
Biju


> 
> > +       depends on MFD_RZ_MTU3 || COMPILE_TEST
> > +       help
> > +         Enable support for MTU3 counter driver found on Renesas
> RZ/G2L alike
> > +         SoCs. This IP supports both 16-bit and 32-bit phase
> counting mode
> > +         support.
> > +
> >  config MFD_STM32_LPTIMER
> >         tristate "Support for STM32 Low-Power Timer"
> >         depends on (ARCH_STM32 && OF) || COMPILE_TEST
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a
> hacker. But when I'm talking to journalists I just say "programmer" or
> something like that.
>                                 -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux