On 10/20/22 07:11, Andrew Lunn wrote:
On Wed, Oct 19, 2022 at 07:23:26PM -0700, Florian Fainelli wrote:
On 10/19/2022 1:35 AM, Yoshihiro Shimoda wrote:
Add Renesas Ethernet Switch driver for R-Car S4-8 to be used as an
ethernet controller.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
How can this be a switch driver when it does not include any switchdev
header files nor does it attempt to be using the DSA framework? You are
certainly duplicating a lot of things that DSA would do for you like
managing PHYs and registering per-port nework devices. Why?
Hi Florian
It is not clear yet if this is actually a DSA switch. I asked these
questions a few revisions ago and it actually looks like it is a pure
switchdev switch. It might be possible to make it a DSA switch. It is
a bit fuzzy, since it is all internal and integrated.
We were dealing with an integrated Ethernet MAC and switch back in 2014
when DSA was resurrected to support bcm_sf2 + bcmsysport, also, we are
about to get support for in-band DSA tags with Maxime's patch series.
I suppose that as long as the binding is conforming, we can always make
the driver evolve, it would be good to see all of the pieces now though.
--
Florian
