RE: [PATCH 2/6] can: rcar_canfd: Add max_channels to struct rcar_canfd_hw_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> <biju.das@xxxxxxxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/6] can: rcar_canfd: Add max_channels to struct
> rcar_canfd_hw_info
> 
> On Sat, Oct 22, 2022 at 1:13 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > R-Car V3U supports a maximum of 8 channels whereas rest of the SoCs
> > support 2 channels.
> >
> > Add max_channels variable to struct rcar_canfd_hw_info to handle
> this
> > difference.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> > --- a/drivers/net/can/rcar/rcar_canfd.c
> > +++ b/drivers/net/can/rcar/rcar_canfd.c
> > @@ -525,6 +525,7 @@ struct rcar_canfd_global;
> >
> >  struct rcar_canfd_hw_info {
> >         enum rcanfd_chip_id chip_id;
> > +       u32 max_channels;
> 
> Although I wouldn't mind "unsigned int" instead...

OK. Agreed will change it to unsigned int.

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux