On 19/10/2022 21:31, Yoshihiro Shimoda wrote: > Hi Krzysztof, > >> From: Krzysztof Kozlowski, Sent: Wednesday, October 19, 2022 9:38 PM >> >> On 19/10/2022 04:35, Yoshihiro Shimoda wrote: >>> Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0). >>> >>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> >> >> Thank you for your patch. There is something to discuss/improve. > > Thank you for your review! > >>> + ethernet-ports: >>> + type: object >>> + additionalProperties: false >>> + >>> + properties: >>> + '#address-cells': >>> + description: Port number of ETHA (TSNA). >>> + const: 1 >>> + >>> + '#size-cells': >>> + const: 0 >>> + >>> + patternProperties: >>> + "^port@[0-9a-f]+$": >>> + type: object >>> + $ref: /schemas/net/ethernet-controller.yaml# >>> + unevaluatedProperties: false >>> + >>> + properties: >>> + reg: >>> + description: >>> + Port number of ETHA (TSNA). >>> + >>> + phy-handle: true >>> + >>> + phy-mode: true >> >> Why do you need these two properties here? They are provided by >> ethernet-controller, so I suggest to drop them. >> >> I already commented about it in v3. > > I'm sorry. I misunderstood you comments. I thought I should drop > "description" on these properties and "enum" on the phy-mode. > I'll drop them on v5. If the enum on phy-mode is different than what ethernet-controller.yaml brings, then please keep it. Just remove everything which is already provided by ethernet-controller.yaml (and does not differ). > Best regards, Krzysztof
