Hi Philipp Zabel,
Thanks for the review.
> Subject: Re: [PATCH v8 2/2] pwm: Add support for RZ/G2L GPT
>
> Hi Biju,
>
> On Di, 2022-10-11 at 14:41 +0100, Biju Das wrote:
> [...]
> > +static int rzg2l_gpt_probe(struct platform_device *pdev) {
> [...]
> > + ret = reset_control_deassert(rzg2l_gpt->rstc);
> > + if (ret)
> > + return dev_err_probe(&pdev->dev, ret,
> > + "cannot deassert reset control\n");
> > +
> > + rzg2l_gpt->clk = devm_clk_get(&pdev->dev, NULL);
> > + if (IS_ERR(rzg2l_gpt->clk))
> > + return dev_err_probe(&pdev->dev, PTR_ERR(rzg2l_gpt->clk),
> > + "cannot get clock\n");
>
> If devm_clk_get() fails, the reset stays deasserted. Better deassert
> after devm_clk_get().
Will fix this in next version.
Cheers,
Biju
