> Subject: Re: [PATCH v4 4/4] mfd: Add RZ/G2L MTU3 PWM driver
>
> On 10/10/2022 10:52, Biju Das wrote:
> > Add support for RZ/G2L MTU3 PWM driver. The IP supports following
> PWM
> > modes
> >
> > 1) PWM mode{1,2}
> > 2) Reset-synchronized PWM mode
> > 3) Complementary PWM mode{1,2,3}
> >
> > This patch adds basic pwm mode 1 support for RZ/G2L MTU3 driver by
> > creating separate logical channels for each IOs.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v3->v4:
> > * There is no resource associated with "rz-mtu3-pwm" compatible
> > and moved the code to mfd subsystem as it binds against "rz-mtu".
> > * Removed struct platform_driver rz_mtu3_pwm_driver.
> > v2->v3:
> > * No change.
> > v1->v2:
> > * Modelled as a single PWM device handling multiple channles.
> > * Used PM framework to manage the clocks.
> > ---
> > drivers/mfd/Kconfig | 6 +
> > drivers/mfd/Makefile | 2 +
> > drivers/mfd/rz-mtu3-pwm.c | 405
> > ++++++++++++++++++++++++++++++++++++++
>
> That's not a MFD driver. That's a PWM. Use proper subsystem and email
> prefix.
See [1]
[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20221006135717.1748560-2-biju.das.jz@xxxxxxxxxxxxxx/
It is a single driver that binds against "renesas,rz-mtu3", and registers both the counter and the pwm
functionalities. Just like the clock driver, which registers clock, reset, and PM Domain functionalities.
It is same here, a single MFD driver which binds against ""renesas,rz-mtu3" and registers counter
And pwm functionalities.
rz-mtu-core is core driver which provides resources to child devices like counter and pwm.
I already copied PWM subsystem in the loop. Am I missing anything related to [1]
Cheers,
Biju
